-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flickering on lines #5094
Fix flickering on lines #5094
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5094 +/- ##
===========================================
- Coverage 89.06% 67.54% -21.53%
===========================================
Files 269 269
Lines 38386 38392 +6
Branches 2370 1479 -891
===========================================
- Hits 34189 25930 -8259
- Misses 3188 11625 +8437
+ Partials 1009 837 -172 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I've tested the test fails without the fix. You can see the error here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
The problem was that we were calling a function that changed the stencil value used even if we were not using the result of it. Wrapping everything with an
if
block made it workLaunch Checklist
CHANGELOG.md
under the## main
section.