Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flickering on lines #5094

Merged
merged 11 commits into from
Nov 22, 2024
Merged

Fix flickering on lines #5094

merged 11 commits into from
Nov 22, 2024

Conversation

ibesora
Copy link
Collaborator

@ibesora ibesora commented Nov 21, 2024

The problem was that we were calling a function that changed the stencil value used even if we were not using the result of it. Wrapping everything with an if block made it work

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.54%. Comparing base (94e2729) to head (751f04b).
Report is 6 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (94e2729) and HEAD (751f04b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (94e2729) HEAD (751f04b)
9 8
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5094       +/-   ##
===========================================
- Coverage   89.06%   67.54%   -21.53%     
===========================================
  Files         269      269               
  Lines       38386    38392        +6     
  Branches     2370     1479      -891     
===========================================
- Hits        34189    25930     -8259     
- Misses       3188    11625     +8437     
+ Partials     1009      837      -172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ibesora
Copy link
Collaborator Author

ibesora commented Nov 22, 2024

I've tested the test fails without the fix. You can see the error here.
I've also in-lined the data needed, simplifying it as much as I could to reproduce the bug, and renamed the function to make clear it's updating the stencil id value

@ibesora ibesora requested a review from HarelM November 22, 2024 16:03
Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@HarelM HarelM merged commit eb334ec into maplibre:main Nov 22, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Globe: Flickering and missing layers when panning/zooming
2 participants