Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style-spec package, added render test #5132

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Update style-spec package, added render test #5132

merged 3 commits into from
Nov 28, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Nov 28, 2024

Launch Checklist

Fixes #5103 - which was partially implemented in the previous version.

This is by updating the style-spec package which has the relevant fix for this issue.
I've also added some render tests to showcase the issue/solution.

For more information, see here:

@louwers please check if you need to exclude this folder as well from the parity tests.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Add an entry to CHANGELOG.md under the ## main section.

@louwers
Copy link
Collaborator

louwers commented Nov 28, 2024

No this sounds like a change that should show up as a disparity.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (86ea129) to head (a7c7f90).
Report is 3 commits behind head on main.

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5132      +/-   ##
==========================================
+ Coverage   91.81%   91.82%   +0.01%     
==========================================
  Files         278      278              
  Lines       38346    38346              
  Branches     6706     6705       -1     
==========================================
+ Hits        35208    35212       +4     
+ Misses       3005     3001       -4     
  Partials      133      133              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit 8dba921 into main Nov 28, 2024
17 checks passed
@HarelM HarelM deleted the geometry-type-fix branch November 28, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoJSON layers not behaving as expected when using ["geometry-type"]
3 participants