Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback to mapbox gl draw example #5138

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Dec 1, 2024

I think it's best to roll back this for now. I learned a ton about the library in the process of migrating, and want to reconsider the approach taken.

This mapbox gl draw examples still has it's turf.js dependency upgraded compared to before.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (5f800b6) to head (e1f9881).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5138   +/-   ##
=======================================
  Coverage   91.83%   91.84%           
=======================================
  Files         278      278           
  Lines       38347    38347           
  Branches     6707     6707           
=======================================
+ Hits        35215    35218    +3     
+ Misses       3000     2997    -3     
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit 9a85e82 into maplibre:main Dec 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants