Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor globe transfrom #5140

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Refactor globe transfrom #5140

wants to merge 9 commits into from

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Dec 1, 2024

Launch Checklist

See here:

This is a WIP to refactor globe transform to move all the logic that is related to globe to a different transform keeping only the transition logic in the globe class and creating a new class for virtual perspective.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 93.97590% with 15 lines in your changes missing coverage. Please review.

Project coverage is 91.83%. Comparing base (9a85e82) to head (d5a6cf8).

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

Files with missing lines Patch % Lines
src/geo/projection/globe_transform.ts 83.87% 15 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5140   +/-   ##
=======================================
  Coverage   91.82%   91.83%           
=======================================
  Files         278      278           
  Lines       38347    38366   +19     
  Branches     6705     6710    +5     
=======================================
+ Hits        35213    35233   +20     
  Misses       3001     3001           
+ Partials      133      132    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant