Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples related to WebGL configuration changes #5218

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ibesora
Copy link
Collaborator

@ibesora ibesora commented Dec 16, 2024

This PR updates some examples that were still using the old syntax to set canvas context attributes

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@ibesora ibesora requested a review from HarelM December 16, 2024 10:06
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (5ad1709) to head (738fc1c).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5218      +/-   ##
==========================================
+ Coverage   91.82%   91.83%   +0.01%     
==========================================
  Files         281      281              
  Lines       38807    38807              
  Branches     6766     4940    -1826     
==========================================
+ Hits        35635    35640       +5     
+ Misses       3044     3040       -4     
+ Partials      128      127       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS!

@HarelM
Copy link
Collaborator

HarelM commented Dec 16, 2024

I wish we could somehow run typescript check on the script in the HTML files to know up front that these issues exist...

@HarelM HarelM changed the title Update examples Update examples related to WebGL configuration changes Dec 16, 2024
@HarelM HarelM merged commit d325252 into maplibre:main Dec 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants