Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added geoJSON source getBounds method #5403
base: main
Are you sure you want to change the base?
Added geoJSON source getBounds method #5403
Changes from 26 commits
427b8b8
4447079
424ab5c
4790824
ad8cf0a
15c6d00
e53ead9
7a6e82f
3016268
a9640a4
038fc08
0a161f1
6ce70fb
d8ac930
f805489
ac7afa1
c112544
6c3e0cd
7455aff
91a8193
944c5d9
873b344
a471b2c
2c493a1
3a2e5c7
8c60411
0c49eda
fffd20d
c629dee
059b744
f33c64a
6fd45ca
d2642b7
3cce7b8
bbe2976
cde489c
9b5274c
6db2340
97ed09c
7f41246
47c0856
d323876
99a7b9e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is what I would expect as a return value...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, if the source has no data, its bounding box should be empty
Check warning on line 294 in src/source/geojson_source.ts
src/source/geojson_source.ts#L261-L294
Check failure on line 511 in test/integration/browser/browser.test.ts
test/integration/browser/browser.test.ts > GeoJSONSource#getBounds > FeatureCollection
Check failure on line 517 in test/integration/browser/browser.test.ts
test/integration/browser/browser.test.ts > GeoJSONSource#getBounds > Feature
Check failure on line 524 in test/integration/browser/browser.test.ts
test/integration/browser/browser.test.ts > GeoJSONSource#getBounds > GeometryCollection
Check failure on line 530 in test/integration/browser/browser.test.ts
test/integration/browser/browser.test.ts > GeoJSONSource#getBounds > Geometry