Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mapbox specifics and branding from .github #64

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

marcelnormann
Copy link
Contributor

Just text editing, did not touch .workflow to avoid breaking things too soon.

@github-actions
Copy link
Contributor

Bundle size report:

Size Change: 0 B
Total Size Before: 201 kB
Total Size After: 201 kB

Output file Before After Change
mapbox-gl.js 196 kB 196 kB 0 B
mapbox-gl.css 4.62 kB 4.62 kB 0 B
ℹ️ View Details No major changes

Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Just a tiny nit -- would be better to use your personal fork to create PRs -- would keep the primary repo clean from dev branches (unless it's a new direction of the whole project relevant to everyone, etc).

P.S. Feel free to merge

@nyurik nyurik merged commit c873efd into main Feb 19, 2021
@nyurik nyurik deleted the fix-mapbox-specifics branch February 19, 2021 20:55
@nyurik
Copy link
Member

nyurik commented Feb 19, 2021

Merged - benign change that also fixes a minor annoyance with the line endings.

@petr-pokorny-1 petr-pokorny-1 added this to the 1.14.0 milestone Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants