Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move output files from mapbox.* to maplibre.* #75

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Move output files from mapbox.* to maplibre.* #75

merged 3 commits into from
Feb 17, 2021

Conversation

Joxit
Copy link
Contributor

@Joxit Joxit commented Feb 8, 2021 •
edited
Loading

Rename mapbox to maplibre

  • Renaming dist/mapbox.* to dist/maplibre.* files.
  • Rename global variable mapboxgl to maplibregl.

related #27

@Joxit Joxit force-pushed the mapbox-to-maplibre branch from 665e073 to 6a981d4 Compare February 8, 2021 13:24
@Joxit Joxit force-pushed the mapbox-to-maplibre branch from 6e9c34e to 6d4fea1 Compare February 15, 2021 13:32
@Joxit
Copy link
Contributor Author

Joxit commented Feb 15, 2021

I created a new variable MAPLIBRE_MAP_STYLE for debug pages (in folder debug), enter the full URL of your favorite style.

Some of the examples can't work because our sources/sprites/glyphs do not match mapbox ones...

CI: Analyze / check-size should fail because the output name has changed.

petrsloup
petrsloup reviewed Feb 17, 2021
View reviewed changes
Copy link
Contributor

@petrsloup petrsloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes the output file name and the global namespace of the library, otherwise most of the changes are in the debug/test HTMLs.

Would be nice to somehow fix the CI before merging, otherwise LGTM.

@Joxit Joxit force-pushed the mapbox-to-maplibre branch 2 times, most recently from fe658c2 to 6a981d4 Compare February 17, 2021 17:19
nyurik
nyurik approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work!

@Joxit Joxit force-pushed the mapbox-to-maplibre branch from bfc4df8 to 68d08d7 Compare February 17, 2021 17:57
@Joxit Joxit force-pushed the mapbox-to-maplibre branch from 68d08d7 to 1e0e32d Compare February 17, 2021 20:44
@nyurik nyurik merged commit e60fb15 into maplibre:main Feb 17, 2021
@Joxit Joxit deleted the mapbox-to-maplibre branch February 17, 2021 21:34
@petr-pokorny-1 petr-pokorny-1 added this to the 1.14.0 milestone Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrsloup petrsloup petrsloup left review comments

@nyurik nyurik nyurik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Joxit @petrsloup @nyurik @petr-pokorny-1