Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor benchmarks #900

Merged
merged 5 commits into from
Jan 27, 2022
Merged

Refactor benchmarks #900

merged 5 commits into from
Jan 27, 2022

Conversation

birkskyum
Copy link
Member

Break up the components to individual files, and refactor most from react classes to functional components.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2022

Bundle size report:

Size Change: 0 B
Total Size Before: 194 kB
Total Size After: 194 kB

Output file Before After Change
maplibre-gl.js 184 kB 184 kB 0 B
maplibre-gl.css 9.5 kB 9.5 kB 0 B
ℹ️ View Details No major changes

@birkskyum birkskyum requested a review from wipfli January 27, 2022 18:09
Copy link
Contributor

@wipfli wipfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look at your source code, but from a user perspective, this seems to do the same as before. Thanks for refactoring!

@wipfli wipfli merged commit 1dbb63c into maplibre:main Jan 27, 2022
@HarelM
Copy link
Collaborator

HarelM commented Jan 27, 2022

Nice work! This is how it should've been written in the first place :-)

wipfli added a commit to wipfli/maplibre-gl-js that referenced this pull request Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants