-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbol layer flickering after zooming out #16
Comments
Hi, I am the reporter of the issue mapbox/mapbox-gl-native#16471. Actually, I have a custom patch for some flickering issues, and I have uploaded it to ystsoi@52c2ce7. The patch is for Mapbox, and I have not tested it against MapLibre. However, I think that it should work on MapLibre too, please try it. |
Thanks for help @ystsoi ! The patch seems to work well. I have tested it on Android. Here is video before fix |
@ystsoi |
Hi, thank you for the patch! It works pretty well on Android. |
Update: After upgrading Mapbox IOS SDK to the last version using https://github.com/react-native-mapbox-gl/maps/blob/master/ios/install.md#mapbox-maps-sdk the problem disappear! |
@gokugen, the provided link you've posted has nothing to do with MapLibre though - I'm posting this to make you aware of that. THIS repo is MapLibre, when you follow the steps in (https://github.com/react-native-mapbox-gl/maps/blob/master/ios/install.md#mapbox-maps-sdk ) you will update the SDK version of the Mapbox iOS SDK, not of the MapLibre SDK. |
This PR is updating the version of this image's parent (`bionicbase`) to keep this image (`maplibreglnativeprivate`) up-to-date. It will be merged if all tests pass via `/merge-skip-owners`; if tests do not pass, it will require manual intervention. For more details please see the [docs about Automatic Updates](https://docs.lyft.net/eng/provisioningdocs/learning/automatic_updates.html). [Here is what's changed in `bionicbase`](lyft/containers@8cfc73e...20c7e22). REVIEWS WERE BYPASSED
Mapbox 6.0 got an update for this (unfortunately after license change):
source 1: https://github.com/mapbox/mapbox-gl-native-ios/blob/master/platform/ios/CHANGELOG.md
source 2: mapbox/mapbox-gl-native#16473 (comment)
Found this issue in maplibre-gl-native android as well as ios.
Unfortunately I could not find any original commit in mapbox-gl-native repo for the mentioned fixes. I pretty sure its in the closed code therefore.
Perhaps someone has an idea where to begin for fixing this.
By the way: older versions of mapbox-gl-native-android (e.g. 8.6.7) does not have this issue (not yet tested for older ios versions).
The text was updated successfully, but these errors were encountered: