Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Windows build on CI with MBGL_EGL = ON #917

Closed
louwers opened this issue Mar 20, 2023 · 4 comments · Fixed by #2968
Closed

Run Windows build on CI with MBGL_EGL = ON #917

louwers opened this issue Mar 20, 2023 · 4 comments · Fixed by #2968
Labels
build Related to build, configuration or CI/CD PR is more than welcomed windows

Comments

@louwers
Copy link
Collaborator

louwers commented Mar 20, 2023

We have a regression because some files were not compiled on CI.

If someone could look into making sure we compile these files on CI, that would prevent regressions in the future.

This is the file in question (there might be more).

platform/windows/src/headless_backend_egl.cpp
@louwers louwers added build Related to build, configuration or CI/CD PR is more than welcomed windows labels Mar 20, 2023
@louwers
Copy link
Collaborator Author

louwers commented Mar 20, 2023

Note CI is also not running: #918

@acalcutt
Copy link
Collaborator

acalcutt commented Mar 20, 2023

How would you want to do this? It would need to be built with different options since the default node build has MBGL_WITH_EGL=OFF . We would have to add the -DMBGL_WITH_EGL=ON option to the configure step ( https://github.com/maplibre/maplibre-gl-native/blob/main/.github/workflows/node-ci.yml#L163-L169 ) , and if we did that it wouldn't test the non-EGL mode.

I could maybe add a variable to the matirix and add a few more os runs.... or maybe maybe a copy of this ci that runs an EGL build...

@acalcutt
Copy link
Collaborator

acalcutt commented Mar 20, 2023

I think ci doesn't run on that PR because the paths are restricted and don't include the windows/linux/macos platform.
https://github.com/maplibre/maplibre-gl-native/blob/main/.github/workflows/node-ci.yml#L30-L45

@etnav
Copy link
Contributor

etnav commented Mar 21, 2023

Flag is called MBGL_WITH_EGL, was a typo I made 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to build, configuration or CI/CD PR is more than welcomed windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants