-
-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows to CI tests #2968
Add Windows to CI tests #2968
Conversation
Bloaty Results (iOS) 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2968-compared-to-main.txt |
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2968-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2968-compared-to-legacy.txt |
Benchmark Results ⚡
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2968-compared-to-main.txt |
d909aa5
to
9465a26
Compare
3f4a7f8
to
b281110
Compare
124e79e
to
34387e3
Compare
11404ee
to
fc75f09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should disable the metrics for Windows. It's going to be a bit of a pain to have to update them for yet another platform when changing anything. Actually I think ideally we should have some workflow to update the metrics automatically on a PR.
Anyway, that is a concern for later. LGTM!
Well, maybe. But redoing metrics it's kind of easy to do. My biggest concern here is testing on Qt platform, so I still need @ntadej to update the Docker image to use CMake 3.24. |
@tdcosta100 I think the plan is to drop support for Qt5. Would that be sufficient? |
I think so, but until then, how can we pass this PR in the tests? |
Either ignore the Qt workflows (they are not required for merging) or remove all matrix blocks in qt-ci that mention Qt 5. https://github.com/maplibre/maplibre-native/blob/main/.github/workflows/qt-ci.yml#L80-L87 Windows workflows seem to be timing out... |
I will see what's going wrong and also update it to match the main branch. |
9c61338
to
44a455e
Compare
Found the reason. With the release of CMake 3.31, |
44a455e
to
093d465
Compare
c40e4ae
to
f675c7e
Compare
f675c7e
to
ad15d29
Compare
I fixed the Qt5 configuration in this branch, CMake version is bigger than 3.24, so everything works as indended. Now tests are passing flawlessly (at least for while). |
Looks OK to me! Sorry for silence, I was very busy lately. |
@ntadej No worries, thanks for having a look! |
Until now, except for Node-CI, Windows didn't have tests yet. So now I'm adding them, based on Linux-CI. I created a matrix with 4 renderers (OpenGL, EGL, Vulkan and OSMesa), and 2 rendering modes (Legacy and Drawable). Two combinations are disabled:
I left some considerations on ignored tests, so others can investigate and fix them in the future. Also, some unit and render tests appear to have specific Windows issues (like font rendering, for example, which will always have some differences, and some number precision issues), so I tweaked these cases, but this is not a definitive solution and suggestions are welcome.
Closes #917