Run macOS workflows only on opengl-2 branch
#1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louwers
added
macOS
github_actions
|
We should still build on main to make sure the code compiles. Only tests should be disabled. |
|
@ntadej Do you think we should disable the tests or still run them for the |
|
In In |
|
@ntadej I enabled the macOS Objective-C tests on The Node CI fails to build due to a missing header on macOS.
This is the case. |
|
Let me see what all is involved in keeping mac building on main - we probably need to create stub gl* functions to satisfy the linker. |
alexcristici
approved these changes
Apr 13, 2023
TimSylvester
added a commit
to WetDogWeather/maplibre-gl-native
that referenced
this pull request
Apr 14, 2023
…awable-1 * commit 'f100a4c5d6449307547c2da850db04b12c6a3a95': Minor reorg of defines. Removed more commented code. Removed commented code. Upgrade OpenGL backend to ES 3.0 (maplibre#995) Run macOS workflows only on `opengl-2` branch (maplibre#1012) Roll back linux metrics submit along with macos metrics. (maplibre#1009)
ntadej
pushed a commit
to ntadej/maplibre-native
that referenced
this pull request
Apr 15, 2023
ntadej
pushed a commit
to ntadej/maplibre-native
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new branch
opengl-2that will stay on OpenGL 2.0 while the renderer modularization and Metal backend implementation are underway. This branch can still be used with macOS. Themainbranch will start using OpenGL ES 3.0 after #995 is merged.