Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-fly-to-with-padding #1454

Merged
merged 8 commits into from
Aug 10, 2023
Merged

add-fly-to-with-padding #1454

merged 8 commits into from
Aug 10, 2023

Conversation

JulianBissekkou
Copy link
Collaborator

No description provided.

@JulianBissekkou JulianBissekkou changed the title Draft: add-fly-to-with-padding add-fly-to-with-padding Aug 3, 2023
@JulianBissekkou JulianBissekkou requested a review from mwilsnd August 3, 2023 06:12
@JulianBissekkou JulianBissekkou added enhancement New feature or request iOS labels Aug 3, 2023
@louwers louwers self-requested a review August 3, 2023 09:35
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this makes sense since MLNMapCamera can have a altitude/viewingDistance.

@1ec5 Do you know why something like this was never added?

platform/ios/src/MLNMapView.mm Outdated Show resolved Hide resolved
platform/ios/src/MLNMapView.h Show resolved Hide resolved
platform/ios/src/MLNMapView.h Outdated Show resolved Hide resolved
@louwers
Copy link
Collaborator

louwers commented Aug 4, 2023

Thanks for sharing your thoughts @1ec5!

@JulianBissekkou
Copy link
Collaborator Author

This tries to improve #1462 by adding the same method to iOS that is already available on android

Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this helps. Note that I’m just gesticulating wildly based on code inspection. I haven’t tried my suggestions out in the current codebase, and it’s been years since I had my hands on this code.

platform/ios/src/MLNMapView.h Outdated Show resolved Hide resolved
platform/ios/src/MLNMapView.h Show resolved Hide resolved
platform/ios/src/MLNMapView.mm Outdated Show resolved Hide resolved
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's revisit this API when we introduce a Swift API for MapLibre Native.

@louwers louwers merged commit 07aaeeb into maplibre:main Aug 10, 2023
@JulianBissekkou JulianBissekkou deleted the add-fly-to-with-padding branch August 10, 2023 11:24
louwers pushed a commit to louwers/maplibre-native that referenced this pull request Aug 11, 2023
Co-authored-by: Julian Bissekkou <julian.bissekkou@tapped.dev>
Co-authored-by: Stefan Schaller <stefan.schaller@tapped.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iOS
Projects
Development

Successfully merging this pull request may close these issues.

4 participants