Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style switching delay fix when annotations are visible #2395

Merged
merged 3 commits into from
May 17, 2024
Merged

Style switching delay fix when annotations are visible #2395

merged 3 commits into from
May 17, 2024

Conversation

alexcristici
Copy link
Collaborator

@alexcristici alexcristici commented May 15, 2024 •
edited
Loading

Before:

Before.MP4

After:

After.MP4

@alexcristici alexcristici self-assigned this May 15, 2024
@alexcristici alexcristici linked an issue May 15, 2024 that may be closed by this pull request
Style Switching Delay #2337
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2395-compared-to-main.txt

@alexcristici alexcristici marked this pull request as ready for review May 16, 2024 07:08
@alexcristici alexcristici mentioned this pull request May 16, 2024
Closed
@alexcristici alexcristici linked an issue May 16, 2024 that may be closed by this pull request
Line annotations don't appear immediately on iOS #2380
Closed
TimSylvester
TimSylvester approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@TimSylvester TimSylvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. That could use an explanatory comment so that someone doesn't later "optimize" it by removing what appears to be a redundant assignment.

sjg-wdw
sjg-wdw approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@sjg-wdw sjg-wdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@alexcristici alexcristici merged commit 0d3b1d7 into maplibre:main May 17, 2024
19 checks passed
@alexcristici alexcristici deleted the style-switching-delay-fix-when-annotations-are-visible branch May 17, 2024 19:47
@louwers louwers mentioned this pull request May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjg-wdw sjg-wdw sjg-wdw approved these changes

@TimSylvester TimSylvester TimSylvester approved these changes

@cgalvan cgalvan cgalvan approved these changes

@stefankarschti stefankarschti stefankarschti approved these changes

@louwers louwers Awaiting requested review from louwers

@mwilsnd mwilsnd Awaiting requested review from mwilsnd

Assignees

@alexcristici alexcristici

Labels
None yet
Projects
MapLibre Native Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Line annotations don't appear immediately on iOS Style Switching Delay
5 participants
@alexcristici @stefankarschti @cgalvan @TimSylvester @sjg-wdw