Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid logging error for onMove(0,0) on Android #2580

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Avoid logging error for onMove(0,0) on Android #2580

merged 3 commits into from
Jul 9, 2024

Conversation

kodebach
Copy link
Contributor

@kodebach kodebach commented Jul 5, 2024

Fixes #2575

@kodebach kodebach mentioned this pull request Jul 5, 2024
Closed
@louwers louwers self-requested a review July 9, 2024 09:59
@louwers
Copy link
Collaborator

louwers commented Jul 9, 2024

@kodebach I replaced Timber here. Could you have a look?

Will merge if it looks OK to you.

@kodebach
Copy link
Contributor Author

kodebach commented Jul 9, 2024

LGTM using if (Float.isNaN makes it a lot clearer what's going on.

@louwers louwers enabled auto-merge (squash) July 9, 2024 11:16
@louwers louwers merged commit 1a3aff0 into maplibre:main Jul 9, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louwers louwers louwers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not call onMove with parameters 0.0,0.0
2 participants
@kodebach @louwers