Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timestamps for attribute updates #2629

Merged
merged 23 commits into from
Aug 20, 2024

Conversation

TimSylvester
Copy link
Collaborator

@TimSylvester TimSylvester commented Jul 17, 2024

Attribute vectors and buffers should track the last time at which they were updated. For efficiency, the vectors still use a private dirty flag internally, to avoid querying the time for each individual value added, which is checked at the end of the update process and the update time adjusted appropriately. And non-shared attribute data still uses a simple dirty flag.

Also incorporates #2615

Resolves #2628

@TimSylvester TimSylvester added the bug Something isn't working label Jul 17, 2024
@TimSylvester TimSylvester self-assigned this Jul 17, 2024
Copy link

github-actions bot commented Jul 17, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2% +28.8Ki  +0.2% +32.0Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2629-compared-to-main.txt

Copy link

github-actions bot commented Jul 17, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +50.0Ki  +0.0% +2.68Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2629-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +27% +31.0Mi  +420% +25.1Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2629-compared-to-legacy.txt

Copy link

github-actions bot commented Jul 17, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0037         +0.0039             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2629-compared-to-main.txt

@TimSylvester TimSylvester marked this pull request as ready for review July 18, 2024 21:56
@TimSylvester
Copy link
Collaborator Author

The codecov results seem spurious

@TimSylvester TimSylvester merged commit fceaa18 into maplibre:main Aug 20, 2024
34 of 38 checks passed
@TimSylvester TimSylvester deleted the profile-perf-2 branch August 20, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Symbol attributes not updated
3 participants