Take locks before signaling thread condition variables #2636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When notifying condition variables for the thread pool, it is possible that threads are just about to wait on the variable at the same time an external thread is about to notify. This can result in the notification being lost, and threads get stuck sleeping. Taking the condition locks prior to notifying prevents this from happening. This was most commonly observed with jobs sent to a sequenced scheduler which only has 1 worker thread.