Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ESM in Node.js code generation scripts #2739

Merged
merged 13 commits into from
Aug 23, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Aug 20, 2024

  • Updates Bazel dependency rules_nodejs and rules_js.
  • Use Node 20 when Bazel runs Node.js (default is Node 16).
  • Use ES modules with Node.js code generation scripts.

@louwers louwers added build Related to build, configuration or CI/CD dependencies Pull requests that update a dependency file labels Aug 20, 2024
Copy link

github-actions bot commented Aug 21, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2739-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +27% +31.0Mi  +420% +25.1Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2739-compared-to-legacy.txt

Copy link

github-actions bot commented Aug 21, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0003         +0.0008             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2739-compared-to-main.txt

Copy link

github-actions bot commented Aug 21, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2739-compared-to-main.txt

@louwers louwers merged commit 8ad4a51 into maplibre:main Aug 23, 2024
38 checks passed
@louwers louwers deleted the node-scripts-esm branch August 23, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to build, configuration or CI/CD dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants