-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group descriptor sets by binding frequency #2892
Group descriptor sets by binding frequency #2892
Conversation
for more information, see https://pre-commit.ci
…ocaru/maplibre-native into layer-descriptor-sets
for more information, see https://pre-commit.ci
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2892-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2892-compared-to-legacy.txt |
Benchmark Results ⚡
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2892-compared-to-main.txt |
…tive into layer-descriptor-sets
…tive into layer-descriptor-sets
for more information, see https://pre-commit.ci
…ocaru/maplibre-native into layer-descriptor-sets
…tive into layer-descriptor-sets
Bloaty Results (iOS) 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2892-compared-to-main.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide more context for this PR in the PR description?
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a bit more logically laid out now too.
Looks like the only effect in Metal/GL is to change around the indexes where things are bound? |
@TimSylvester In general yes. It reorders some enum values so that all layer specific ids are contiguous. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Descriptors are "pointers" to a resource (buffer, texture, sampler, etc) that are meant to be grouped in sets and bound to a pipeline to be consumed in subsequent drawing commands.
Currently the descriptors are batched in a single set and updated/bound for each drawable at render time. This PR aims to group the descriptors by update frequency (one global/layer/drawable) and reduce the overall number of binds per frame.