Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line atlas #2908

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix line atlas #2908

merged 1 commit into from
Oct 8, 2024

Conversation

TimSylvester
Copy link
Collaborator

I think this came from the fill layer or something, but doesn't make sense here. We can potentially share some of these, because they are generated in the worker and assigned to multiple buckets, but we would have to use a map and look them up not just have a single cache item, and that's probably not worth it.

Resolves #2735

@TimSylvester TimSylvester added the bug Something isn't working label Oct 7, 2024
@TimSylvester TimSylvester self-assigned this Oct 7, 2024
Copy link
Collaborator

@sjg-wdw sjg-wdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Copy link

github-actions bot commented Oct 7, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2908-compared-to-main.txt

Copy link
Collaborator

@alexcristici alexcristici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

github-actions bot commented Oct 7, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0% -8.71Ki  -0.0% -1.74Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2908-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +28% +32.6Mi  +426% +25.4Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2908-compared-to-legacy.txt

Copy link

github-actions bot commented Oct 7, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0106         -0.0107             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2908-compared-to-main.txt

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a regression test?

@louwers louwers changed the title Line atlas fix Fix for line atlas Oct 8, 2024
@louwers louwers changed the title Fix for line atlas Fix line atlas Oct 8, 2024
@louwers louwers merged commit eaa52d0 into maplibre:main Oct 8, 2024
42 checks passed
@louwers louwers deleted the bug/2735 branch October 8, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Metal: Incorrect reuse of sprites for line-pattern
4 participants