-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode the style URL in iOS #2965
Conversation
Please add a unit test to |
Bloaty Results (iOS) 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2965-compared-to-main.txt |
@louwers |
@qqz003 Yes that sounds good. The |
@louwers Looks that I don't have the write access to merge the PR, could you please help to merge it? Thank you! |
@qqz003 Thanks for the reminder! |
This reverts commit d140d5e.
@qqz003 @random3940 I had to revert this change due to regressions. Happy to work with you to address this in another way... |
For iOS versions under 17.0,
[NSURL URLWithString:]
cannot create anNSURL
object with the url string that containing any characters that need to be encoded. Consequently, it cannot load the custom style correctly if the style file contains such a URL.