Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move node nvmrc to platform/node #3018

Merged
merged 3 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/node-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ jobs:
- name: Use Node.js from nvmrc
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
node-version-file: 'platform/node/.nvmrc'

- name: npm ci
working-directory: platform/node
Expand Down Expand Up @@ -297,7 +297,7 @@ jobs:
GALLIUM_DRIVER: softpipe
run: |
Invoke-WebRequest https://github.com/pal1000/mesa-dist-win/releases/download/22.3.5/mesa3d-22.3.5-release-msvc.7z -OutFile mesa3d.7z
& 'C:\Program Files\7-Zip\7z.exe' e -olib\node-v115 .\mesa3d.7z x64\opengl32.dll x64\libgallium_wgl.dll x64\libGLESv2.dll x64\libglapi.dll
& 'C:\Program Files\7-Zip\7z.exe' e -olib\node-v131 .\mesa3d.7z x64\opengl32.dll x64\libgallium_wgl.dll x64\libGLESv2.dll x64\libglapi.dll
npm test

# On PRs make sure that the npm package can be packaged.
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/node-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Use Node.js from nvmrc
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
node-version-file: 'platform/node/.nvmrc'

- name: Check if version is published
id: check
Expand Down Expand Up @@ -115,7 +115,7 @@ jobs:
- name: Use Node.js from nvmrc
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
node-version-file: 'platform/node/.nvmrc'

- name: npm ci
working-directory: platform/node
Expand Down Expand Up @@ -270,7 +270,7 @@ jobs:
- name: Use Node.js from nvmrc
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
node-version-file: 'platform/node/.nvmrc'

- name: Get version
id: package-version
Expand Down
1 change: 1 addition & 0 deletions platform/node/.nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
23
Loading