Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded ccache Android build config #3041

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Nov 25, 2024

Closes #2911

@adrian-cojocaru Could you check if this works on Windows?

  • Add platform/android/MaplibrePlugin Gradle root. I added a Gradle plugin there that configures ccache for so we can share that logic between MapLibre Android, the render test app and the C++ test app.
  • Rewrite Groovy of render test app project and C++ test app project to Kotlin.
  • Don't use ccache during release workflow (risk of cache poisoning).
  • Also try sccache if ccache is not available.
  • Use CMAKE_CXX_COMPILER_LAUNCHER instead of ANDROID_CCACHE. Not sure if it matters.

@louwers louwers added build Related to build, configuration or CI/CD android labels Nov 25, 2024
@louwers louwers closed this Nov 25, 2024
@adrian-cojocaru
Copy link
Collaborator

Checked. Works

@louwers louwers reopened this Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3041-compared-to-main.txt

Copy link

github-actions bot commented Nov 25, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3041-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +30% +34.5Mi  +432% +25.8Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3041-compared-to-legacy.txt

Copy link

github-actions bot commented Nov 25, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0008         -0.0007             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3041-compared-to-main.txt

@louwers louwers enabled auto-merge (squash) November 26, 2024 02:37
@louwers louwers merged commit ed84444 into maplibre:main Nov 26, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android build Related to build, configuration or CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ccache env variable
2 participants