Use MapLibre Android as attribution string across languages #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platform/android/MapLibreAndroid/src/main/res/values-ko/strings.xml
Outdated
Show resolved
Hide resolved
platform/android/MapLibreAndroid/src/main/res/values-ko/strings.xml
Outdated
Show resolved
Hide resolved
…s.xml Co-authored-by: Ian Wagner <ianwagner+github@switzerlandmail.ch>
…s.xml Co-authored-by: Ian Wagner <ianwagner+github@switzerlandmail.ch>
|
@ianthetechie Lol & fixed. :) |
platform/android/MapLibreAndroid/src/main/res/values-ko/strings.xml
Outdated
Show resolved
Hide resolved
…s.xml Co-authored-by: Ian Wagner <ianwagner+github@switzerlandmail.ch>
ianthetechie
approved these changes
Dec 11, 2024
cgalvan
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we tend to drop the 'SDK' and also the 'for', and just call the library 'MapLibre Android', I updated the attribution strings to match this across languages.
For Korean 안드로이드를 위한 맵박스 맵 SDK was used (translates to Mapbox Map SDK for Android). @ianthetechie recommended dropping the transliteration as MapLibre Android is more recognizable.