Release build scripts for Metal support #50
Conversation
|
Approved and here are my testing results. No changes required to perform archiving and distro on TestFlight, good job @petr-pokorny-1 and I say its ready for you to merge into
Archiving test of the
Estimated App Store file sizes and descriptions from TestFlight at App Store Connect |
| @@ -106,11 +106,17 @@ make xcframework | |||
| step "Zipping xcframeworks…" | |||
| MAPBOX_ZIP_FILE="Mapbox-${PUBLISH_VERSION}.zip" | |||
| (cd ${BINARY_DIRECTORY} && rm -f ${MAPBOX_ZIP_FILE} && zip -yr ${MAPBOX_ZIP_FILE} Mapbox.xcframework) | |||
| METAL_ANGLE_ZIP_FILE="MetalANGLE-${PUBLISH_VERSION}.zip" | |||
| (cd ${BINARY_DIRECTORY} && rm -f ${METAL_ANGLE_ZIP_FILE} && zip -yr ${METAL_ANGLE_ZIP_FILE} MetalANGLE.xcframework) | |||
There was a problem hiding this comment.
The version numbers of the binaries are as below, but I think this script pulls the {PUBLISH_VERSION} from the git tags. If we cannot tag the MetalANGLE, then we may be able to use the binaries version as it is on disk.
| .binaryTarget( | ||
| name: "MetalANGLE", | ||
| url: "METAL_ANGLE_PACKAGE_URL", | ||
| checksum: "METAL_ANGLE_PACKAGE_CHECKSUM") |
There was a problem hiding this comment.
For future reviewers (assume Petr already knows this)
Please see notes at maplibre/maplibre-gl-native-distribution#5 on how to test locally built *.xcframeworks with SPM.
| echo "Creating ${METAL_ANGLE_NAME}.xcframework with args: $BUILD_ARGS" | ||
| xcodebuild -create-xcframework $BUILD_ARGS | ||
| echo "${METAL_ANGLE_NAME}.xcframework created" | ||
|
|
This PR integrates MetalANGLE framework into release build scripts and fixes iOS test app and Benchmark app.