Improve hillshade layers not using raster-dem sources error message #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the errors around adding
hillshade
layers that don't use araster-dem
source.Before this PR, adding a
hillshade
layer with araster
source saidlayer \"test\" requires a vector source"
which is not right.With this PR, the same use case results in the following error:
layer \"test\" requires a raster-dem source
.It also adds a couple of tests to check that and an extra one that tests a condition that was not met before (using a
raster-dem
source type on layers that are nothillshade
)Launch Checklist
CHANGELOG.md
under the## main
section.