Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove <!-- copyeditor --> comment from rendered docs #355

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Remove <!-- copyeditor --> comment from rendered docs #355

merged 1 commit into from
Sep 28, 2023

Conversation

flother
Copy link
Contributor

@flother flother commented Sep 28, 2023

Currently, on the Sprite page of the Maplibre Style Spec docs, an HTML comment is being rendered as text:

When the Markdown is rendered as HTML the < in <!-- copyeditor ignore retext-passive --> is being escaped as &lt; and so the comment is appearing in the docs. The comment is probably some leftover debris from when https://npm.io/package/@mapbox/copyeditor was being used (pre-fork?). It's the only instance of a <!-- copyeditor --> comment in the docs, and so it seems the safest/easiest thing to do is simply remove it.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!

This is being rendered as text on the page, rather than being treated as
an HTML comment and hidden. Likely leftover from when
https://npm.io/package/@mapbox/copyeditor was used for the docs.
@HarelM
Copy link
Collaborator

HarelM commented Sep 28, 2023

This looks good. Thanks!
In the past there were a few images in this page to explain the stretch part of the shields.
@birkskyum so you know what happened to those? Can we bring them back?

@birkskyum birkskyum merged commit edeaee3 into maplibre:main Sep 28, 2023
6 checks passed
@birkskyum
Copy link
Member

birkskyum commented Sep 28, 2023

Thank you @flother .

@HarelM , I unfortunately don't remember these pictures. Maybe we can find an old version of the docs that has them still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants