-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export v8.json file as latest.json in dist folder #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarelM
commented
Jan 11, 2024
In order to import it in maputnik I'll be using the following line: import latest from '@maplibre/maplibre-gl-style-spec/dist/latest.json' I think it's OK. |
birkskyum
approved these changes
Jan 11, 2024
neodescis
reviewed
Jan 11, 2024
neodescis
approved these changes
Jan 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #490 +/- ##
==========================================
+ Coverage 92.09% 92.22% +0.13%
==========================================
Files 100 100
Lines 4176 4195 +19
Branches 1197 1202 +5
==========================================
+ Hits 3846 3869 +23
+ Misses 330 326 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
This copies the v8.json file into dist/latest.json to allow other libraries to import it and use it.
The exported variable is stripped from the docs and sdk as part of the build to reduce package size.
Fixes #489
I'm not sure this is the best solution to this, but I don't have another one at the moment...
I also improved some of the types while I upgraded maputnik to latest version where I found out about this issue.
CHANGELOG.md
under the## main
section.