Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homepage to package.json #843

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Add homepage to package.json #843

merged 1 commit into from
Oct 2, 2024

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Oct 1, 2024

Useful to add. You can type npm home from command line to see the style spec in browser :-)

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

Useful to add. You can type `npm home` from command line to see the style spec in browser :-)
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (947b273) to head (e994d06).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #843   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files         105      105           
  Lines        4646     4646           
  Branches     1312     1312           
=======================================
  Hits         4307     4307           
  Misses        339      339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Collaborator

HarelM commented Oct 1, 2024

Is there a need to update the lock file or is this not part of what's written there?

@coliff
Copy link
Contributor Author

coliff commented Oct 2, 2024

no need to update package-lock (running npm i would add it if it was needed, but it doesn't).

@HarelM HarelM merged commit e29a32b into maplibre:main Oct 2, 2024
6 checks passed
@coliff coliff deleted the patch-1 branch October 2, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants