Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical-perspective projection. Clarify that globe is an adaptive preset. #890

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Nov 7, 2024

With the expression syntax well underway, it seems there's a clear need for adding the General Perspective projection (general-perspective) in that way that doesn't break later. It serves as a non-adaptive globe until the expression is in.

We can too clarify that the "globe" is, and will stay as, an adaptive preset that use the general-perspective and mercator projections.

Having the genereral-projection option in GL JS early can help us begin preparing for the introduction of the expressions.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (5788145) to head (8fdaf62).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #890   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files         105      105           
  Lines        4683     4683           
  Branches     1323     1323           
=======================================
  Hits         4343     4343           
  Misses        340      340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@birkskyum birkskyum marked this pull request as draft November 7, 2024 06:50
@birkskyum birkskyum marked this pull request as ready for review November 7, 2024 06:53
@birkskyum birkskyum changed the title Add stereographic projection. Clarify that globe is an adaptive preset. Add general-perspective projection. Clarify that globe is an adaptive preset. Nov 7, 2024
@HarelM
Copy link
Collaborator

HarelM commented Nov 7, 2024

Let me know which PR to review first and if we can/should push this PR or the other one first.

@birkskyum
Copy link
Member Author

birkskyum commented Nov 7, 2024

This one is ready to merge, so we can begin making GL JS support the non-mercator high-zoom case (with floating point errors, as noted by Jakub), and simply toggling between mercator and general-perspective.

The projection expression work needs some more time.

@HarelM
Copy link
Collaborator

HarelM commented Nov 7, 2024

Feel free to push this forward.

@birkskyum birkskyum merged commit d7444b4 into maplibre:main Nov 7, 2024
6 checks passed
@birkskyum birkskyum changed the title Add general-perspective projection. Clarify that globe is an adaptive preset. Add vertical-perspective projection. Clarify that globe is an adaptive preset. Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants