Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move types, clean imports, move interpolate method #903

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Nov 15, 2024

Launch Checklist

This PR is mainly a refactoring of exiting code.
There were some classes that were placed in utils instead of types folder.
I moved the code around to fix that.
Also removed the deprecated interpolation factory.
I moved the imports to be at the begging of the file where I saw that this was not the case.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 92.64706% with 10 lines in your changes missing coverage. Please review.

Project coverage is 92.79%. Comparing base (89713fd) to head (7efa923).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/expression/types/color.ts 84.84% 5 Missing ⚠️
src/expression/definitions/interpolate.ts 77.77% 4 Missing ⚠️
src/expression/index.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
+ Coverage   92.73%   92.79%   +0.05%     
==========================================
  Files         105      105              
  Lines        4683     4689       +6     
  Branches     1323     1323              
==========================================
+ Hits         4343     4351       +8     
+ Misses        340      338       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM requested a review from birkskyum November 15, 2024 07:49
@HarelM
Copy link
Collaborator Author

HarelM commented Nov 15, 2024

@birkskyum I believe you are familiar with most of the code changes here.
Let me know if something here is not clear.

@@ -0,0 +1,9 @@
export function interpolateNumber(from: number, to: number, t: number): number {
Copy link
Member

@birkskyum birkskyum Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will try to bench the two lerps against each other at some point - for the fun of it :)

Copy link
Member

@birkskyum birkskyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is definitely better

@birkskyum birkskyum merged commit 8cb30d3 into main Nov 15, 2024
6 checks passed
@birkskyum birkskyum deleted the move-types branch November 15, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants