-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named exports #904
Named exports #904
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
==========================================
- Coverage 92.79% 92.77% -0.02%
==========================================
Files 105 105
Lines 4689 4677 -12
Branches 1323 1323
==========================================
- Hits 4351 4339 -12
Misses 338 338 ☔ View full report in Codecov by Sentry. |
@@ -1,4 +1,4 @@ | |||
export default function extendBy(output: any, ...inputs: Array<any>) { | |||
export function extendBy(output: any, ...inputs: Array<any>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this can be removed now and we can use some typescript functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extendBy is doing the same as:
Object.assign(output, ...inputs);
But our eslint settings doesn't like Object.assign
https://eslint.org/docs/latest/rules/no-restricted-properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep it for now then, it's out of scope for this PR...
I think it's a big enough change to add to the changelog, even if it's only refactoring. |
I left the config files rollup/jest/eslint, but everything else is named exports. I've sometimes just mapped the name, so it's just the import line that changes, without affecting the re-exports, or other logic.
Since this is strictly only an internal change, I don't know if a changelog bullet is needed.
Launch Checklist
CHANGELOG.md
under the## main
section.