Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 22.0.0 #909

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Bump version to 22.0.0 #909

merged 2 commits into from
Nov 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@birkskyum
Copy link
Member

birkskyum commented Nov 17, 2024

@HarelM , I made this as a Major release, because of regression concerns ( #905 ). Since we distribute .mjs, .cjs and .d.ts files, I find it increasingly problematic that our test-build suite, due to Jest 29, only can check for regressions in the .cjs bundle - with the rest of the world moving to the .mjs and .d.ts.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (c5f8f8d) to head (dfc0339).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #909   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         107      107           
  Lines        4739     4739           
  Branches     1346     1346           
=======================================
  Hits         4397     4397           
  Misses        342      342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Collaborator

HarelM commented Nov 17, 2024

Wasn't vertical perspective a breaking change?
In any case, major here won't hurt anyone I believe...

@birkskyum
Copy link
Member

birkskyum commented Nov 17, 2024

@HarelM , the vertical perspective was not breaking, see https://github.com/maplibre/maplibre-style-spec/pull/890/files - it just added another new option to the enum, effectively only changing/relaxing the typings, but the existing mercator/globe options kept working as expecting.

@birkskyum birkskyum merged commit f5afe41 into main Nov 17, 2024
6 checks passed
@birkskyum birkskyum deleted the bump-version-to-22.0.0 branch November 17, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants