Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting features causes properties to be non-equal in tests #186

Open
springmeyer opened this issue Jun 21, 2024 · 1 comment
Open

Sorting features causes properties to be non-equal in tests #186

springmeyer opened this issue Jun 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@springmeyer
Copy link
Collaborator

springmeyer commented Jun 21, 2024

When sorting features in bing tiles the tests fail on property comparison.

For example, with bing tile 4-8-5:

Here is an MVT property:

 mvtProperties: {label-importance=6, has-icon=true, max-text-width=100.0, st-tag=sovCap, name=Copenhagen, bkt=1822, id=7016673626309001217, name-f=16.0, clk-as=lbl}

And here is the MLT property:

 mltProperties: {label-importance=4, has-icon=true, max-text-width=100.0, name=Budapest, bkt=2094, name-f=16.0}

Perhaps the lack of feature IDs in bing tiles is causing this?

Could be a bug in the test comparison code, since it works off feature ids.

To workaround this (and be able to compare sorted features in the tests) we may need to add auto-incrementing support to features that lack an ID (or where it is always zero in the MVT)?

springmeyer added a commit to springmeyer/maplibre-tile-spec that referenced this issue Jun 21, 2024
@springmeyer springmeyer added the bug Something isn't working label Jun 21, 2024
@mactrem
Copy link
Collaborator

mactrem commented Jun 22, 2024

Yes, sorting is currently only possible if an id is present. Because of this I also do not sort the Bing tiles in the size benchmark tests. I only did a quick implementation of the sorting strategy so it is limited. In general a more sophisticated sorting strategy has the potential to noticeably further reduce the tile size. This is on my list to do a more advanced implementation of the sorting

springmeyer added a commit that referenced this issue Jun 25, 2024
Currently we do not fully test all these combinations:

 - Vectorized path + advanced encodings
 - Vectorized path + without advanced encodings
 - Non-Vectorized path + advanced encodings
 - Non-Vectorized path + without advanced encodings
 
This PR starts testing all those paths.

The code coverage changes are:

 - **overall:** `36%`to `45%`
 - **mlt.converter:** `64%` to `85%`
 - **mlt.decoder:** `55%` to `71%`

In addition this PR includes:

- Some refactoring in TestUtils.java to share more code between
vectorized and non-vectorized
- Improvements to TestUtils.java around geometry comparisons (refs #178)
 - Improvements to TestUtils.java around property comparisons

Finally, this PR does not attempt to solve any bugs. Rather it finds,
isolates, and writes tests harnesses to capture them in code. Once bugs
are solved in the future it should be easy to update the tests
accordingly.

TODO:
- [x] ~This PR uncovered a number of bugs that do not have open issues
and did not have tests that hit them until now. So I need to create
following issues to capture fixing these.~
     - Added:
        - #181
        - #182 
        - #183 
        - #184
        - #185
        - #186
- [ ] Property nesting in MLT makes comparison to MVT difficult so I
disabled it in this test refactor because comparison to MVT is what the
decoder tests rely on. My sense is that standalone unit tests of nesting
might be more appropriate than including nesting in the decoder tests.
Do others agree?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants