Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node 6 test builds #379

Closed
wants to merge 1 commit into from
Closed

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Sep 12, 2018

Also added node 10

@orangemug
Copy link
Collaborator

orangemug commented Sep 15, 2018

@nyurik thanks for the PR, but unfortunately I'm planning to remove travisCI as now we have CircleCI running all the tests.

For reference issues with travis were, that it was taking a long time to build (occasionally many hours). Also with CircleCI we get per commit builds, because they host our artifacts for us. This means we can share a build in the PR, like in issue #323

@orangemug orangemug closed this Sep 15, 2018
@nyurik nyurik deleted the rm_node_6_build branch September 17, 2018 19:09
@nyurik
Copy link
Member Author

nyurik commented Sep 17, 2018

@orangemug thanks! I wasn't sure what was causing the failed build status on the repo, thought it was travis. Thx for looking into it!

@orangemug
Copy link
Collaborator

It turns out it was 00b22eb causing the issue. I managed to merge a failing PR somewhere along the way.... ooops! Once #358 is merge should be passing again.

Note: #358 is failing because of Appveyor, but I'm assuming Appveyor is just having a funny 5 mins, as it's happened before and I don't have a window box to test on. I'll push another blank commit to force and build and get these tests passing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants