Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color accessibility UI #392

Merged
merged 8 commits into from
Oct 6, 2018

Conversation

orangemug
Copy link
Collaborator

@orangemug orangemug commented Sep 23, 2018

Raising this pull request for feedback. This is a first attempt for a color accessibility UI.

My thoughts are that because the map can only be in one state at a time to bundle it in with the Maps Inspect/Map toggle.

screen shot 2018-09-23 at 14 43 02

Demo: https://892-84182601-gh.circle-artifacts.com/0/artifacts/build/index.html#0.36/0/0
Fixes #323

Thoughts and feedback appreciated

Note: I'll fix failing tests when we're happy with the UI

@pathmapper
Copy link
Contributor

Makes sense to me to put it there and I like it 👍

Maybe adding tooltips with a short explanation of the different options, like:

  • deuteranopia -> red-green color blindness
  • protanopia -> red-green color blindness
  • tritanopia -> blue-yellow color blindness
  • achromatopsia -> total color blindness

@pathmapper
Copy link
Contributor

This PR is also a welcome improvement regarding information which map state is active.
Currently you know you are in map mode because you are able to switch to inspect mode and vice versa.

@orangemug
Copy link
Collaborator Author

Hey @pathmapper there is a new build with the tests fixed

https://995-84182601-gh.circle-artifacts.com/0/artifacts/build/index.html#0.35/0/0

This uses a regular <select/> now, reason being that there were a few UX issues with the previous version.

@orangemug orangemug merged commit 44fad76 into maplibre:master Oct 6, 2018
@pathmapper
Copy link
Contributor

pathmapper commented Oct 6, 2018

@orangemug using Chrome on Linux the text color of the options is not distinguishable from the background:

image

Adding the following to _toolbar.scss fixes this for the dropdown, but after selecting an option the selected option is not distinguishable from the background again.

.maputnik-toolbar-select select option{
  color: #1c1f24;
}

Adding color: #1c1f24 !important; to .maputnik-toolbar-select select fixes the font color issue for me in every case, but there must be a proper solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build UI for color accessibility filters
2 participants