-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color accessibility UI #392
Color accessibility UI #392
Conversation
…essibility-ui Conflicts: src/components/App.jsx src/styles/_components.scss
Makes sense to me to put it there and I like it 👍 Maybe adding tooltips with a short explanation of the different options, like:
|
This PR is also a welcome improvement regarding information which map state is active. |
Hey @pathmapper there is a new build with the tests fixed https://995-84182601-gh.circle-artifacts.com/0/artifacts/build/index.html#0.35/0/0 This uses a regular |
@orangemug using Chrome on Linux the text color of the options is not distinguishable from the background: Adding the following to _toolbar.scss fixes this for the dropdown, but after selecting an option the selected option is not distinguishable from the background again.
Adding |
Raising this pull request for feedback. This is a first attempt for a color accessibility UI.
My thoughts are that because the map can only be in one state at a time to bundle it in with the Maps Inspect/Map toggle.
Demo: https://892-84182601-gh.circle-artifacts.com/0/artifacts/build/index.html#0.36/0/0
Fixes #323
Thoughts and feedback appreciated
Note: I'll fix failing tests when we're happy with the UI