Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #553

Merged
merged 5 commits into from
Oct 12, 2019

Conversation

orangemug
Copy link
Collaborator

@orangemug orangemug commented Oct 10, 2019

Changes

  • Update all the dependencies
  • Change from using raw-loader to babel-plugin-static-fs as it needs API updates anyway and seemed like a simpler approach

Build: https://1458-84182601-gh.circle-artifacts.com/0/artifacts/build/index.html

Does anybody fancy giving it a try, see if they can find anything broken?

@pathmapper
Copy link
Contributor

Thanks @orangemug, I'll try this out.

@orangemug
Copy link
Collaborator Author

Thanks @pathmapper

package.json Outdated Show resolved Hide resolved
Co-Authored-By: pathmapper <pathmapper@posteo.de>
@pathmapper
Copy link
Contributor

@orangemug this PR removes the package-lock.json and adds a yarn.lock. Was this intended?

@orangemug
Copy link
Collaborator Author

Yeah @pathmapper it was intentional, however now you've made me reconsider. I think yarn is 'better' because it appears to create a more consistent lockfile. However a lot of people won't have yarninstalled. So I favour of making it easier to contribute to Maputnik, npm lockfiles are probably better.

I'll regenerate the package-lock.jsonand remove yarn.lock. Thanks for questioning it.

@orangemug
Copy link
Collaborator Author

I'll regenerate the package-lock.json and remove yarn.lock. Thanks for questioning it.

I've updated the PR

@pathmapper
Copy link
Contributor

@orangemug I didn't found anything broken and think it's good to merge. Also checked some changelogs if there were any breaking changes which could affect us.

@orangemug
Copy link
Collaborator Author

Thanks @pathmapper merging!

@orangemug orangemug merged commit 369cc23 into maplibre:master Oct 12, 2019
@pathmapper
Copy link
Contributor

@orangemug what about a v1.6.1 release including this PR and bda7a0e?

The not working OMT styles on https://maputnik.github.io/editor/ are bad UX ...

@orangemug
Copy link
Collaborator Author

@pathmapper
Copy link
Contributor

@orangemug great, I'll take care of the CLI binaries.

@orangemug
Copy link
Collaborator Author

I'll take care of the CLI binaries.

Thanks

@pathmapper
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants