-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links to tile provider authentication docs #914
Conversation
Should there also be a "Stadia Maps Access Token" field? |
It's not required for most web browser uses; I'll add one either this weekend or Monday. I see I also missed updating(?) some tests. Will look at that too. |
@HarelM any blockers for this one? |
Yes, translation is now needed for text. |
Got side tracked on a few other projects, but got back to adding the token support in the latest edits. Thanks for letting me know about the translation @HarelM! I didn't know that was a thing 😅 I've also added a few lines explaining that to the README. |
Yes, translation was added very recently. |
Thanks! |
Wait, what about the translation of the text you added? |
Ack.
I'll address both momentarily. |
I think adding a description like other fields is a good idea. |
Took a while for me to get back to this again, but I overcame the event and i18n issues finally ;) The only thing remaining is getting the new strings translated. I also see the i8n plugin keeps weirdly rewriting the file, so a bit of manual cleanup required for some strings. |
Looks good, thanks! |
Co-authored-by: Joscha <34318751+josxha@users.noreply.github.com>
Co-authored-by: Joscha <34318751+josxha@users.noreply.github.com>
Co-authored-by: Hugues Tavernier <hugues.tavernier@protonmail.com>
Co-authored-by: Hugues Tavernier <hugues.tavernier@protonmail.com>
Ok... I think the only outstanding item now are translations from @keichan34 @jieme |
We'll give it a few days and then decide if we merge as is or do something else. |
Co-authored-by: Keitaroh Kobayashi <keita@kbys.me>
I'll merge it like that, if people are interested in seeing Maputnik in their language, they can contribute the relevant translation I guess... |
This probably confused some people in the past, since vector tiles won't even display an access denied image ;)
Before (no information on access keys and where to get them):
After (add links to providers in info callout + add a field for Stadia Maps API keys):