New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/910: Fix CORS warning for localhost #939

Open

oobayly wants to merge 2 commits into maplibre:main from oobayly:issue/910

oobayly commented Sep 23, 2024 •

edited

Loading

See #910

As per the issue, test the hostname of the for a localhost URL, by

Domain - localhost
IPv4 localhost subnet - 127.0.0.1/8
IPv6 localhost - [::1]

Launch Checklist

Briefly describe the changes in this PR.
Link to related issues.
Include before/after visuals or gifs if this PR includes visual changes.
Write tests for all new functionality.
Add an entry to CHANGELOG.md under the ## main section.

oobayly added 2 commits

September 23, 2024 16:00


          issue/910: Fix CORS warning for localhost

aa6e055

See maplibre#910

Don't show CORS warning for localhost


          issue/910: Fix linting errors

ab1e6ff

Collaborator

HarelM commented Sep 23, 2024

Can you add a test to make sure this will be kept solved in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet