Create base from UI #1142
Create base from UI #1142
Conversation
(cherry picked from commit d82a237)
| @@ -0,0 +1,30 @@ | |||
| # React + TypeScript + Vite | |||
There was a problem hiding this comment.
this needs updating - I would prefer not to check in unrelated boilerplate readme
| @@ -0,0 +1,20 @@ | |||
| import martinCover from './assets/martin-cover.png' | |||
There was a problem hiding this comment.
this image is somewhat incorrect - martin is not only focused on large databases... Not sure what to say there - maybe even leave it at empty-ish, or use the martin's main documentation string?
| @@ -96,6 +104,15 @@ pub fn router(cfg: &mut web::ServiceConfig) { | |||
|
|
|||
| #[cfg(feature = "fonts")] | |||
| cfg.service(crate::srv::fonts::get_font); | |||
|
|
|||
| #[cfg(feature = "webui")] | |||
| cfg.service(actix_web_static_files::ResourceFiles::new( | |||
There was a problem hiding this comment.
there is a subtle bug here - compiled files go into /assets/... - but the word assets could also be the name of a tile source. Is there a way we can make the root /index.html use /_/assets/... path instead? The _ is a reserved keyword, so we should put everything non-stable there.
|
@tomeronen i merged in the changes from the main branch. Let me know if you need any help with this |
|
FYI, Maputnik has been moved to maplibre, and so is the maplibre-gl-inspect, with lots of work being done on them. Any updates on this PR? |
|
@tomeronen @nyurik I'd be happy to help out on this if you'd like! |
Any help is welcome! Thx 😊 |
|
I made some changes and submitted them here #1395 |
Add an optional web UI interface for Martin, including docker-based cross-compilation support. The UI itself is a placeholder with a logo, but will grow in subsequent PRs. This was branched off of #1142 to address the PR feedback from @nyurik . --------- Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com> Co-authored-by: Tomer Ronen <tomer207@gmail.com> Co-authored-by: tomeronen <45331634+tomeronen@users.noreply.github.com>
|
(sorry to bother: given that @paigewilliams' PR #1395 is merged, I think this PR should is redundant ^^) |
|
I'll check shortly, ie if it has any extra code that might still be useful? |
|
All changes from these PRs were done in #1395. Thx for all the hard work that lead to adding static hosting! |
Starting to build the UI step by step. This is the first step contains basic setup discussions about the libraries to use, and building the code as part of the martin build and serving it from the binariy :