Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactivate s2 calculations and tests on macos #131

Merged
merged 5 commits into from
Jan 21, 2023

Conversation

goergen95
Copy link
Member

Because s2-based calculations have been throwing errors only on MacOS we disabled s2 and instead used lwgeom on these operating systems. This lead to numerically different results thus also tests have been disabled. This PR tries to reactivate s2 and associated tests for MacOS.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2023

Codecov Report

Base: 81.34% // Head: 80.90% // Decreases project coverage by -0.45% ⚠️

Coverage data is based on head (cffcb65) compared to base (c995c04).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   81.34%   80.90%   -0.45%     
==========================================
  Files          39       39              
  Lines        2504     2509       +5     
==========================================
- Hits         2037     2030       -7     
- Misses        467      479      +12     
Impacted Files Coverage Δ
R/calc_indicator.R 72.00% <ø> (+1.45%) ⬆️
R/calc_treecover_area.R 88.31% <ø> (ø)
R/calc_treecover_area_and_emissions.R 79.80% <ø> (ø)
R/calc_treecoverloss_emissions.R 84.41% <ø> (ø)
R/get_nasa_grace.R 70.83% <ø> (ø)
R/get_resource.R 70.27% <ø> (ø)
R/get_nasa_srtm.R 24.32% <100.00%> (-29.25%) ⬇️
R/utils.R 89.02% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@goergen95 goergen95 merged commit fb17ac4 into main Jan 21, 2023
@goergen95 goergen95 deleted the reactivate-tests-on-macos branch January 21, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants