Migrated files from charlies PR #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update handling of installation requirements
|
Still not exactly sure what's different here from my PR... could you update the description please? |
|
There is absolutely no difference.. Sorry this was a bit of a communication error; we were in a meeting and wanted to quickly work on the branch - no changes to your work (apart from 2 or 3 dependencies in setup.cfg). If you want us to redo this from scratch to be more transparent then we can! |
|
Closing this now, superseded by #114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the exact same pull request as #90
it was erroneously created because of my inability to work with a forked repo i didn't have write rights to - and which had conflicts with master. Now I know better :)