Keep imports properly sorted with isort #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great - so when I run "tox" now it will sort the imports automatically correctly? |
matentzn
approved these changes
Aug 31, 2021
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
isortutility to thelintenvironment in tox as well as theflake8-isortplugin to the flake8 quality assurance testing. Since #127 was merged, this means that this check will be run on all PRs. As you can see by the big diff, there's quite a bit of cleanup it already did!One thing to consider later (not for accepting this PR) is that there is a mix of absolute and relative imports. While I'm definitely going against the grain here, I think that packages should only be using relative imports, to remind you never to rely on being able to run python files in packages as scripts (instead, the solution is to pip install then use
python -m ...)