Normalize usage to prefix_map #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
previously approved these changes
Sep 22, 2021
|
@matentzn can you adjust the settings so it's not possible to merge to the master branch without CI tests passing? |
|
I made it harder, but admin can still overwrite if necessary..
|
matentzn
reviewed
Sep 22, 2021
matentzn
approved these changes
Sep 22, 2021
|
Thank you! Somehow the merge button is not red after the approval is given.. but QC is not yet run. Annoying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All instances of
curie_mapandprefixmaphave been normalized toprefix_mapboth in variable names and function names. The notable exception is when interacting with dictionaries coming from SSSOM yaml, where the name is unfortunatelycurie_map- so this is maintained as a constant string calledsssom.util.PREFIX_MAP_KEYin case it's possible we can ever change it.