Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue the descent into Flake8 Hell #156

Merged
merged 3 commits into from
Sep 24, 2021
Merged

Continue the descent into Flake8 Hell #156

merged 3 commits into from
Sep 24, 2021

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Sep 22, 2021

This PR adds flake8 checks for docstrings. I addressed several of the possible checks, and left the rest as ignore for now. We could either accept this PR as is, or work one at a time removing the ignores, addressing them, then moving on.

81mPquqrVLL AC_SL1000

@cthoyt cthoyt changed the title Continue the descend into Flake8 Hell Continue the descent into Flake8 Hell Sep 22, 2021
@cthoyt cthoyt requested a review from matentzn September 24, 2021 11:39
@cthoyt
Copy link
Member Author

cthoyt commented Sep 24, 2021

Actually I think merge fast is a better plan for this one

@matentzn
Copy link
Collaborator

Just now seeing this amazing image..

@matentzn
Copy link
Collaborator

Thank you @cthoyt I salute you!

@cthoyt cthoyt merged commit d78a4be into master Sep 24, 2021
@cthoyt cthoyt deleted the flake8-plunge branch September 24, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants