Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 Round 3: We're going to make you an overnight celebrity #164

Merged
merged 9 commits into from
Oct 8, 2021

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Oct 4, 2021

This PR finishes the last 3 flake8 ignores. It also enables the pydocstyle and darglint plugins, making the bar for writing good docs even higher!.

Click the image for an explanation of the joke.

81mPquqrVLL AC_SL1000-1

@cthoyt cthoyt changed the title Flake8 Round 3: You didn't think we could do it again? Flake8 Round 3: We're going to make you an overnight celebrity Oct 4, 2021
@matentzn
Copy link
Collaborator

matentzn commented Oct 4, 2021

You are crazy.. :D Thank you :)

@cthoyt cthoyt marked this pull request as ready for review October 5, 2021 13:40
@cthoyt cthoyt requested a review from matentzn October 5, 2021 13:54
@cthoyt
Copy link
Member Author

cthoyt commented Oct 5, 2021

@matentzn not sure why CI didn't run on my last commit. Locally, all commands in tox are passing, but I'd ideally like to see it on CI as well before merging.

sssom/cli.py Show resolved Hide resolved
Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eternally thankful, amazing amazing.

@cthoyt cthoyt merged commit 082252f into master Oct 8, 2021
@cthoyt cthoyt deleted the flake8-twista-kanye-celebrity-overnight branch October 8, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants