Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin pyparsing dependency to latest version #314

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Unpin pyparsing dependency to latest version #314

merged 1 commit into from
Sep 19, 2022

Conversation

hrshdhgd
Copy link
Contributor

Fixes #313

@hrshdhgd hrshdhgd requested a review from matentzn September 19, 2022 15:22
matentzn
matentzn approved these changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope our tests are comprehensive enought to catch potential issues with this :)

@matentzn
Copy link
Collaborator

Thank you @hrshdhgd!

@hrshdhgd hrshdhgd merged commit 76a9df9 into master Sep 19, 2022
@hrshdhgd hrshdhgd deleted the issue-313 branch September 19, 2022 16:00
@hrshdhgd
Copy link
Contributor Author

I hope our tests are comprehensive enought to catch potential issues with this :)

The pinning of the version was done because a later version at the time was throwing an error. The fact that the tests pass is an indication that they fixed the issue in subsequent versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update pyparsing
2 participants
@hrshdhgd @matentzn