Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for subject and object categories #257

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

matentzn
Copy link
Collaborator

Solves #256

Resolves [#ISSUE, #ISSUE]

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

[Description, mentioning at least relevant #ISSUE and how it was addressed. A bulleted list of all changes performed by the PR is is helpful.]

@saubin78
Copy link

Thanks, this is much clearer with the category examples in particular.
Yet, there is still something confusing. As you state that this "is documentation for human reviewers", I suggest that the final example be a term label, e.g. "anatomical entity", instead of an identifier "UBERON:0001062".

@matentzn
Copy link
Collaborator Author

@saubin78 thats right, can you check again?

@saubin78
Copy link

This looks like a good compromise as it allows using a controlled vocabulary or not, a label or a CURIE. 👍

@matentzn matentzn merged commit d1028f5 into master Feb 17, 2023
@matentzn matentzn deleted the matentzn-patch-3 branch February 17, 2023 08:32
@matentzn
Copy link
Collaborator Author

Thank you @saubin78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants