Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hot module reload undefined window.process error in development #2143

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

AndrewPhilbin
Copy link
Contributor

See this issue. Pins react-error-overlay dependency to v6.0.9, which should prevent needing to refresh the browser tab to clear the overlay error after every file save in development.

@AndrewPhilbin
Copy link
Contributor Author

This could possibly also be solved by upgrading react-scripts from 4.x.x to 5.x.x, but there are more potential breaking changes via that route.

@codecov-commenter
Copy link

Codecov Report

Merging #2143 (f674d50) into main (8bec650) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main    #2143   +/-   ##
=======================================
  Coverage   24.71%   24.72%           
=======================================
  Files         644      644           
  Lines       22100    22100           
  Branches     6796     6796           
=======================================
+ Hits         5463     5464    +1     
+ Misses      13921    13920    -1     
  Partials     2716     2716           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CollinBeczak CollinBeczak merged commit 45f46ca into main Nov 1, 2023
1 check passed
@ljdelight ljdelight deleted the processUndefinedFix branch November 15, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants